Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMFile: Support modify DMFile meta #9365

Merged
merged 9 commits into from
Aug 30, 2024
Merged

DMFile: Support modify DMFile meta #9365

merged 9 commits into from
Aug 30, 2024

Conversation

Lloyd-Pottiger
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #9032

Problem Summary:

What is changed and how it works?

Pick https://github.com/tidbcloud/tiflash-cse/pull/200

DMFile: Support modify DMFile meta

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 26, 2024
breezewish and others added 6 commits August 29, 2024 16:01
@breezewish @Lloyd-Pottiger
DMFile: Support modify DMFile meta (pingcap#200)
571dfc7 
Signed-off-by: Wish <[email protected]>
@Lloyd-Pottiger
fix license
d6a6252 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
default value
e3b6610 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
remove include
afb9643 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
address comments & add encryption UT
ad1e4ad 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
fix build
82cfbad 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
fix ut
e21284f 
Signed-off-by: Lloyd-Pottiger <[email protected]>
CalvinNeo
CalvinNeo approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 30, 2024
JaySon-Huang
JaySon-Huang reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dbms/src/Storages/DeltaMerge/File/DMFileV3IncrementWriter.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/DeltaMerge/dtpb/dmfile.proto Outdated Show resolved Hide resolved
@Lloyd-Pottiger
address comments
0848553 
Signed-off-by: Lloyd-Pottiger <[email protected]>
JaySon-Huang
JaySon-Huang approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JaySon-Huang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 30, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-30 03:01:06.872276795 +0000 UTC m=+1098462.006726916: ☑️ agreed by CalvinNeo.
  • 2024-08-30 07:59:53.785785855 +0000 UTC m=+1116388.920235971: ☑️ agreed by JaySon-Huang.

@Lloyd-Pottiger Lloyd-Pottiger merged commit 8d95a13 into pingcap:feature/vector-index Aug 30, 2024
4 of 5 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the cherry-pick-4 branch August 30, 2024 10:14
@JaySon-Huang JaySon-Huang mentioned this pull request Sep 30, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@breezewish breezewish Awaiting requested review from breezewish

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lloyd-Pottiger @JaySon-Huang @CalvinNeo @breezewish